| commit | 3040c8203d68a9a0564af81729085054fd6b5b03 | |
| author | Julia Lawall <julia@diku.dk> | |
| Sun, 12 Jul 2009 07:42:47 +0000 (12 09:42 +0200) | ||
| committer | Jiri Kosina <jkosina@suse.cz> | |
| Wed, 22 Jul 2009 23:28:02 +0000 (23 01:28 +0200) | ||
| tree | 5a1036cf9c9fce40f2b9cfb369745fbabb09c987 | treesnapshot (tar.gz zip) |
| parent | 711a680e35059bc5c7c28d3c4bd0bebd3b7bb6ee | commitdiff |
HID: Drop NULL test on list_entry result
list_entry, which is an alias for container_of, cannot return NULL, as
there is no way to add a NULL value to a doubly linked list.
A simplified version of the semantic match that findds this problem is as
follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r@
expression x,E;
statement S1,S2;
position p,p1;
@@
*x = list_entry@p(...)
... when != x = E
*if@p1 (x == NULL) S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
list_entry, which is an alias for container_of, cannot return NULL, as
there is no way to add a NULL value to a doubly linked list.
A simplified version of the semantic match that findds this problem is as
follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r@
expression x,E;
statement S1,S2;
position p,p1;
@@
*x = list_entry@p(...)
... when != x = E
*if@p1 (x == NULL) S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| drivers/hid/hid-lgff.c | diffblobblamehistory |