From 2b12669873c4e2a5b2f9d4ccc84653832b06c2ff Mon Sep 17 00:00:00 2001 From: Adrian Bunk Date: Fri, 15 Dec 2006 00:24:31 +0100 Subject: [PATCH] [ALSA] sound/core/: fix 3 off-by-one errors This patch fixes three off-by-one errors found by the Coverity checker. Signed-off-by: Adrian Bunk --- sound/core/sound.c | 4 ++-- sound/core/sound_oss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/core/sound.c b/sound/core/sound.c index a8eda02bcf1..5ac097605af 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -120,7 +120,7 @@ void *snd_lookup_minor_data(unsigned int minor, int type) struct snd_minor *mreg; void *private_data; - if (minor > ARRAY_SIZE(snd_minors)) + if (minor >= ARRAY_SIZE(snd_minors)) return NULL; down(&sound_mutex); mreg = snd_minors[minor]; @@ -139,7 +139,7 @@ static int snd_open(struct inode *inode, struct file *file) struct file_operations *old_fops; int err = 0; - if (minor > ARRAY_SIZE(snd_minors)) + if (minor >= ARRAY_SIZE(snd_minors)) return -ENODEV; mptr = snd_minors[minor]; if (mptr == NULL) { diff --git a/sound/core/sound_oss.c b/sound/core/sound_oss.c index d0be32b517c..79752205c5c 100644 --- a/sound/core/sound_oss.c +++ b/sound/core/sound_oss.c @@ -45,7 +45,7 @@ void *snd_lookup_oss_minor_data(unsigned int minor, int type) struct snd_minor *mreg; void *private_data; - if (minor > ARRAY_SIZE(snd_oss_minors)) + if (minor >= ARRAY_SIZE(snd_oss_minors)) return NULL; down(&sound_oss_mutex); mreg = snd_oss_minors[minor]; -- 2.11.4.GIT