| commit | efc3dbc37412c027e363736b4f4c74ee5e8ecffc | |
| author | David S. Miller <davem@davemloft.net> | |
| Tue, 24 Jan 2012 22:03:44 +0000 (24 17:03 -0500) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 24 Jan 2012 22:03:44 +0000 (24 17:03 -0500) | ||
| tree | 958b635fa7f52456c19247e892a3d92d21a448a7 | treesnapshot (tar.gz zip) |
| parent | 36a1211970193ce215de50ed1e4e1272bc814df1 | commitdiff |
rds: Make rds_sock_lock BH rather than IRQ safe.
rds_sock_info() triggers locking warnings because we try to perform a
local_bh_enable() (via sock_i_ino()) while hardware interrupts are
disabled (via taking rds_sock_lock).
There is no reason for rds_sock_lock to be a hardware IRQ disabling
lock, none of these access paths run in hardware interrupt context.
Therefore making it a BH disabling lock is safe and sufficient to
fix this bug.
Reported-by: Kumar Sanghvi <kumaras@chelsio.com>
Reported-by: Josh Boyer <jwboyer@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
rds_sock_info() triggers locking warnings because we try to perform a
local_bh_enable() (via sock_i_ino()) while hardware interrupts are
disabled (via taking rds_sock_lock).
There is no reason for rds_sock_lock to be a hardware IRQ disabling
lock, none of these access paths run in hardware interrupt context.
Therefore making it a BH disabling lock is safe and sufficient to
fix this bug.
Reported-by: Kumar Sanghvi <kumaras@chelsio.com>
Reported-by: Josh Boyer <jwboyer@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/rds/af_rds.c | diffblobblamehistory |