| commit | d63dab00e85641515a0a060e6de93e6b7f450665 | |
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | |
| Wed, 14 Jan 2009 02:20:20 +0000 (13 18:20 -0800) | ||
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | |
| Wed, 14 Jan 2009 05:28:39 +0000 (13 21:28 -0800) | ||
| tree | c077a31cfd7da7b0b58419603ba479948dfc57af | treesnapshot (tar.gz zip) |
| parent | 840207edfa8b5e5b46e0d268bf33efe71fecea20 | commitdiff |
Input: omap-keypad - mark probe function as __devinit
A pointer to omap_kp_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
[dtor@mail.ru: fixed some more section markups]
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
A pointer to omap_kp_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
[dtor@mail.ru: fixed some more section markups]
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
| drivers/input/keyboard/omap-keypad.c | diffblobblamehistory |