| commit | 88cc83772a3c7756b9f2b4ba835545ad90a08409 | |
| author | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Sat, 27 Feb 2010 21:45:29 +0000 (27 18:45 -0300) | ||
| committer | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Sat, 27 Feb 2010 21:45:29 +0000 (27 18:45 -0300) | ||
| tree | 317dd539082f7fe26227b1dcf3860433f2e7acfe | treesnapshot (tar.gz zip) |
| parent | b525c06cdbd8a3963f0173ccd23f9147d4c384b5 | commitdiff |
thinkpad-acpi: fix ALSA callback return status
Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.
Rework the volume subdriver to be able to properly implement the ALSA
API. Based on a patch by Clemens Ladisch <clemens@ladisch.de>.
This fix is also needed on 2.6.33.
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.
Rework the volume subdriver to be able to properly implement the ALSA
API. Based on a patch by Clemens Ladisch <clemens@ladisch.de>.
This fix is also needed on 2.6.33.
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
| drivers/platform/x86/thinkpad_acpi.c | diffblobblamehistory |