[PATCH] sysfs: store sysfs inode nrs in s_ino to avoid readdir oopses
commit672aa733e1592cb802259522a5eb89524a97e3b2
authorEric Sandeen <sandeen@sandeen.net>
Mon, 11 Jun 2007 05:02:45 +0000 (11 14:02 +0900)
committerWilly Tarreau <w@1wt.eu>
Wed, 17 Oct 2007 19:30:40 +0000 (17 21:30 +0200)
tree8703014393073308b7d95f25deb2b835562a4a72
parenta58339acdc58993f3e5cdc8124445ae92e31be76
[PATCH] sysfs: store sysfs inode nrs in s_ino to avoid readdir oopses

Backport of
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc1/2.6.22-rc1-mm1/broken-out/gregkh-driver-sysfs-allocate-inode-number-using-ida.patch

For regular files in sysfs, sysfs_readdir wants to traverse
sysfs_dirent->s_dentry->d_inode->i_ino to get to the inode number.
But, the dentry can be reclaimed under memory pressure, and there is
no synchronization with readdir.  This patch follows Tejun's scheme of
allocating and storing an inode number in the new s_ino member of a
sysfs_dirent, when dirents are created, and retrieving it from there
for readdir, so that the pointer chain doesn't have to be traversed.

Tejun's upstream patch uses a new-ish "ida" allocator which brings
along some extra complexity; this -stable patch has a brain-dead
incrementing counter which does not guarantee uniqueness, but because
sysfs doesn't hash inodes as iunique expects, uniqueness wasn't
guaranteed today anyway.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/sysfs/dir.c
fs/sysfs/inode.c
fs/sysfs/mount.c
include/linux/sysfs.h