| commit | 613e901e1ee0e1096663b649eee8e5d6697919f3 | |
| author | Bryan Schumaker <bjschuma@netapp.com> | |
| Wed, 27 Apr 2011 19:28:44 +0000 (27 15:28 -0400) | ||
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | |
| Wed, 27 Apr 2011 20:17:29 +0000 (27 16:17 -0400) | ||
| tree | 1a7c6c79585da11445de9c3b3c6c701d5c6c0195 | treesnapshot (tar.gz zip) |
| parent | 28331a46d88459788c8fca72dbb0415cd7f514c9 | commitdiff |
NFS: Return meaningful status from decode_secinfo()
When compiling, I was getting this warning:
fs/nfs/nfs4xdr.c: In function ‘decode_secinfo’:
fs/nfs/nfs4xdr.c:4839:6: warning: variable ‘status’ set but not used
[-Wunused-but-set-variable]
We were unconditionally returning 0 as long as there wasn't an error
coming out of xdr_inline_decode(). We probably want to check the error
status coming out of decode_op_hdr() and decode_secinfo_gss(), rather
than assuming that everything is OK all the time.
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
When compiling, I was getting this warning:
fs/nfs/nfs4xdr.c: In function ‘decode_secinfo’:
fs/nfs/nfs4xdr.c:4839:6: warning: variable ‘status’ set but not used
[-Wunused-but-set-variable]
We were unconditionally returning 0 as long as there wasn't an error
coming out of xdr_inline_decode(). We probably want to check the error
status coming out of decode_op_hdr() and decode_secinfo_gss(), rather
than assuming that everything is OK all the time.
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
| fs/nfs/nfs4xdr.c | diffblobblamehistory |