| commit | 52840bd628707979b5bbcce3c506786d3a69dba0 | |
| author | Greg Kroah-Hartman <gregkh@suse.de> | |
| Tue, 18 Dec 2007 06:05:35 +0000 (17 23:05 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Fri, 25 Jan 2008 04:40:30 +0000 (24 20:40 -0800) | ||
| tree | 15c9b60fa5884e62706fd86defec2ab749a24bfa | treesnapshot (tar.gz zip) |
| parent | 542eb75a27616bdde95c8d3764e0ab703579f8b5 | commitdiff |
Kobject: the cris iop_fw_load.c code is broken
This code is really really really broken. So much so that it's almost
impossible to fix with a simple patch, so just comment out the offending
registration with the kobject core, and mark the driver as broken.
The problem is that the code is trying to register a "raw" struct
device, which is not allowed. struct device is only for use within the
driver model. This is being done to try to use the firmware layer which
wants a struct device. To properly fix this, use something easy, like a
platform device, which is a struct device and can be used for this kind
of thing.
Cc: Mikael Starvik <starvik@axis.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This code is really really really broken. So much so that it's almost
impossible to fix with a simple patch, so just comment out the offending
registration with the kobject core, and mark the driver as broken.
The problem is that the code is trying to register a "raw" struct
device, which is not allowed. struct device is only for use within the
driver model. This is being done to try to use the firmware layer which
wants a struct device. To properly fix this, use something easy, like a
platform device, which is a struct device and can be used for this kind
of thing.
Cc: Mikael Starvik <starvik@axis.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| arch/cris/arch-v32/drivers/iop_fw_load.c | diffblobblamehistory |