| commit | 48d95ecc9cce93fd091100a2903b0591e6499b03 | |
| author | Nick Piggin <npiggin@suse.de> | |
| Wed, 14 Jan 2009 06:28:16 +0000 (14 07:28 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Sun, 18 Jan 2009 18:35:44 +0000 (18 10:35 -0800) | ||
| tree | eea191f6e558d9d7e28fa331366d2fd75d41dc71 | treesnapshot (tar.gz zip) |
| parent | adb6e972fdee2dc4c3ec4093ab4429233d51b3b4 | commitdiff |
mm: fix assertion
commit 18e6959c385f3edf3991fa6662a53dac4eb10d5b upstream.
This assertion is incorrect for lockless pagecache. By definition if we
have an unpinned page that we are trying to take a speculative reference
to, it may become the tail of a compound page at any time (if it is
freed, then reallocated as a compound page).
It was still a valid assertion for the vmscan.c LRU isolation case, but
it doesn't seem incredibly helpful... if somebody wants it, they can
put it back directly where it applies in the vmscan code.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 18e6959c385f3edf3991fa6662a53dac4eb10d5b upstream.
This assertion is incorrect for lockless pagecache. By definition if we
have an unpinned page that we are trying to take a speculative reference
to, it may become the tail of a compound page at any time (if it is
freed, then reallocated as a compound page).
It was still a valid assertion for the vmscan.c LRU isolation case, but
it doesn't seem incredibly helpful... if somebody wants it, they can
put it back directly where it applies in the vmscan code.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| include/linux/mm.h | diffblobblamehistory |