| commit | 40257b953fdd519c743138f3fbe3962d54991116 | |
| author | Guenter Roeck <guenter.roeck@ericsson.com> | |
| Sat, 10 Sep 2011 13:02:12 +0000 (10 06:02 -0700) | ||
| committer | Guenter Roeck <guenter.roeck@ericsson.com> | |
| Tue, 13 Sep 2011 13:19:15 +0000 (13 06:19 -0700) | ||
| tree | 2e4e8e368b262648d7d96fbd9af4b012551df282 | treesnapshot (tar.gz zip) |
| parent | b6fd41e29dea9c6753b1843a77e50433e6123bcb | commitdiff |
hwmon: (pmbus) Fix low limit temperature alarms
Temperature alarms are detected by checking the alarm bit and comparing
temperature limits against the current temperature. For low limits, this
comparison needs to be reversed (temp < limit instead of temp > limit).
This was not taken into account, resulting in wrong alarms if a temperature
fell below a low limit.
Fix by adding a low limit flag in the limit data structure. When creating the
sensor entry, the order of registers to compare is now reversed for low limits.
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Cc: stable@kernel.org # 3.0+
Temperature alarms are detected by checking the alarm bit and comparing
temperature limits against the current temperature. For low limits, this
comparison needs to be reversed (temp < limit instead of temp > limit).
This was not taken into account, resulting in wrong alarms if a temperature
fell below a low limit.
Fix by adding a low limit flag in the limit data structure. When creating the
sensor entry, the order of registers to compare is now reversed for low limits.
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Cc: stable@kernel.org # 3.0+
| drivers/hwmon/pmbus/pmbus_core.c | diffblobblamehistory |