| commit | 3c4faf9eeb28ede0192e3ebd40d1226d820c882d | |
| author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | |
| Fri, 25 Mar 2011 16:33:57 +0000 (25 18:33 +0200) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 14 Apr 2011 23:52:57 +0000 (14 16:52 -0700) | ||
| tree | 5d8ab6c0da6876645c0a821b11264ee883ea6280 | treesnapshot (tar.gz zip) |
| parent | fadb4c27cf5db424717b921f15ec57869451af51 | commitdiff |
UBIFS: do not read flash unnecessarily
commit 8b229c76765816796eec7ccd428f03bd8de8b525 upstream.
This fix makes the 'dbg_check_old_index()' function return
immediately if debugging is disabled, instead of executing
incorrect 'goto out' which causes UBIFS to:
1. Allocate memory
2. Read the flash
On every commit. OK, we do not commit that often, but it is
still silly to do unneeded I/O anyway.
Credits to coverity for spotting this silly issue.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 8b229c76765816796eec7ccd428f03bd8de8b525 upstream.
This fix makes the 'dbg_check_old_index()' function return
immediately if debugging is disabled, instead of executing
incorrect 'goto out' which causes UBIFS to:
1. Allocate memory
2. Read the flash
On every commit. OK, we do not commit that often, but it is
still silly to do unneeded I/O anyway.
Credits to coverity for spotting this silly issue.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| fs/ubifs/commit.c | diffblobblamehistory |