| commit | 36c92474498ad6cc3afb24b91a67a444d79978fe | |
| author | Ben Hutchings <bhutchings@solarflare.com> | |
| Tue, 17 Jan 2012 07:57:56 +0000 (17 07:57 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 17 Jan 2012 20:49:03 +0000 (17 15:49 -0500) | ||
| tree | 6e847f5256b6ef429ca1a8ea85ede022d0c53cbe | treesnapshot (tar.gz zip) |
| parent | 4144cb2ade46d97b9c41682fd2e9064a59f23a98 | commitdiff |
net: WARN if skb_checksum_help() is called on skb requiring segmentation
skb_checksum_help() has never done anything useful with skbs that
require segmentation. Setting skb->ip_summed = CHECKSUM_NONE makes
them invalid and provokes a later WARNing in skb_gso_segment().
Passing such an skb to skb_checksum_help() indicates a bug, so we
should warn about it immediately. Move the warning from
skb_gso_segment() into a shared function, and add gso_type and
gso_size to it.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
skb_checksum_help() has never done anything useful with skbs that
require segmentation. Setting skb->ip_summed = CHECKSUM_NONE makes
them invalid and provokes a later WARNing in skb_gso_segment().
Passing such an skb to skb_checksum_help() indicates a bug, so we
should warn about it immediately. Move the warning from
skb_gso_segment() into a shared function, and add gso_type and
gso_size to it.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/core/dev.c | diffblobblamehistory |