| commit | 2fb1e3086df9b454538491fba8121298da37cd23 | |
| author | Al Viro <viro@parcelfarce.linux.theplanet.co.uk> | |
| Fri, 19 Aug 2005 21:42:16 +0000 (19 22:42 +0100) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Sat, 20 Aug 2005 00:57:19 +0000 (19 17:57 -0700) | ||
| tree | d84587462e0378c5aa9c5581d6920d76242b8c65 | treesnapshot (tar.gz zip) |
| parent | 91aa9fb573fcc50bc74d5ee64c7e9b36131f1804 | commitdiff |
[PATCH] jffs2: fix symlink error handling
The current calling conventions for ->follow_link() are already fairly
complex.
What we have is
1) you can return -error; then you must release nameidata yourself
and ->put_link() will _not_ be called.
2) you can do nd_set_link(nd, ERR_PTR(-error)) and return 0
3) you can do nd_set_link(nd, path) and return 0
4) you can return 0 (after having moved nameidata yourself)
jffs2 follow_link() is broken - it has an exit where it returns
-EIO and leaks nameidata.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
The current calling conventions for ->follow_link() are already fairly
complex.
What we have is
1) you can return -error; then you must release nameidata yourself
and ->put_link() will _not_ be called.
2) you can do nd_set_link(nd, ERR_PTR(-error)) and return 0
3) you can do nd_set_link(nd, path) and return 0
4) you can return 0 (after having moved nameidata yourself)
jffs2 follow_link() is broken - it has an exit where it returns
-EIO and leaks nameidata.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| fs/jffs2/symlink.c | diffblobblamehistory |