| commit | 0d6ac1dda466721cdb125610cb978389246b4ee0 | |
| author | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Fri, 27 May 2011 01:50:52 +0000 (26 22:50 -0300) | ||
| committer | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Fri, 27 May 2011 01:50:52 +0000 (26 22:50 -0300) | ||
| tree | 98e3f6e1eb7958076f116af2e86e4f6b0afbb288 | treesnapshot (tar.gz zip) |
| parent | 12866d18473d2869b4ccec7fe54da01367a4a1eb | commitdiff |
thinkpad-acpi: fix ALSA callback return status
Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.
Rework the volume subdriver to be able to properly implement the ALSA
API. Based on a patch by Clemens Ladisch <clemens@ladisch.de>.
This fix is also needed on 2.6.33.
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.
Rework the volume subdriver to be able to properly implement the ALSA
API. Based on a patch by Clemens Ladisch <clemens@ladisch.de>.
This fix is also needed on 2.6.33.
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
| drivers/platform/x86/thinkpad_acpi.c | diffblobblamehistory |