inotify: fix race
commit00baa19e1f7f4d6f156578288ecb4c65d62534ad
authorNick Piggin <npiggin@suse.de>
Wed, 6 Feb 2008 09:37:28 +0000 (6 01:37 -0800)
committerOliver Pinter <oliver.pntr@gmail.com>
Wed, 2 Apr 2008 19:10:07 +0000 (2 21:10 +0200)
tree4a494d86ad081b8644e8e97e020f199ab2a93029
parenteec24ff1d57e7917922b2f32c2b18eda5602078d
inotify: fix race

There is a race between setting an inode's children's "parent watched" flag
when placing the first watch on a parent, and instantiating new children of
that parent: a child could miss having its flags set by
set_dentry_child_flags, but then inotify_d_instantiate might still see
!inotify_inode_watched.

The solution is to set_dentry_child_flags after adding the watch.  Locking is
taken care of, because both set_dentry_child_flags and inotify_d_instantiate
hold dcache_lock and child->d_locks.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Robert Love <rlove@google.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: Yan Zheng <yanzheng@21cn.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/inotify.c