From a6b1397310671813148833a9693cca1f2073ba3d Mon Sep 17 00:00:00 2001 From: Gary King Date: Tue, 29 Sep 2015 09:06:34 -0700 Subject: [PATCH] Warn on invalid option name in lift:addtest tests added : no tests run : via hudson performance : no change release note : no, test only Change-Id: Ie6bf639f0b703836e156b391ed181b7d0a2477a5 Reviewed-on: https://gerrit.franz.com:9080/5000 Reviewed-by: Ahmon Dancy Reviewed-by: Gary Warren King Tested-by: Hudson Reviewed-by: John O'Rourke Tested-by: Kevin Layer --- dev/lift.lisp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/dev/lift.lisp b/dev/lift.lisp index f587f91..46b8d75 100644 --- a/dev/lift.lisp +++ b/dev/lift.lisp @@ -1630,7 +1630,17 @@ Test options are one of :setup, :teardown, :test, :tests, :documentation, :expor (defun build-test-case-options (suite-name case-name options) (loop for (k v) on options by #'cddr collect - `(setf (test-case-option ',suite-name ',case-name ,k) ,v))) + (progn + (assert (member k + '(:expected-error + :expected-failure + :expected-problem + :depends-on + :documentation)) + nil + "Unknown option-name ~s when trying to set a test-case-option for ~a/~a" + k suite-name case-name) + `(setf (test-case-option ',suite-name ',case-name ,k) ,v)))) #| (test-case-option 'test-dependencies-helper 'test-c :depends-on) -- 2.11.4.GIT