From f5b3d0eccccfef910be9366c0456973d402d98b5 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Quelin?= <jquelin@gmail.com>
Date: Tue, 15 Jan 2008 19:09:19 +0100
Subject: [PATCH] various cleanups

- I32 -> IV
- removed empty lines between INIT, CODE, OUTPUT
- lined up var declaration
---
 XS.xs | 118 +++++++++++++++++++++++++-----------------------------------------
 1 file changed, 45 insertions(+), 73 deletions(-)

diff --git a/XS.xs b/XS.xs
index a2e5acc..7caa4de 100644
--- a/XS.xs
+++ b/XS.xs
@@ -40,16 +40,14 @@ MODULE = Language::Befunge::Vector::XS		PACKAGE = Language::Befunge::Vector::XS
 #
 SV *
 new( class, array, ... )
-        char*       class;
-        intArray*   array
-
+        char*      class;
+        intArray*  array
     INIT:
-            I32  i;
-            SV*  self;
-            SV*  val;
-            AV*  my_array;
-            HV*  stash;
-
+            IV     i;
+            SV*    self;
+            SV*    val;
+            AV*    my_array;
+            HV*    stash;
     CODE:
         /* create the object and populate it */
         my_array = newAV();
@@ -63,7 +61,6 @@ new( class, array, ... )
         stash = gv_stashpv( class, TRUE );
         sv_bless( (SV*)RETVAL, stash );
         RETVAL = self;
-
     OUTPUT:
         RETVAL
 
@@ -75,21 +72,19 @@ new( class, array, ... )
 # zeroes). LBVXS->new_zeroes(2) is exactly equivalent to LBVXS->new(0, 0).
 #
 SV *
-new_zeroes( class, dimension )
-        char* class;
-        I32   dimension;
-
+new_zeroes( class, dim )
+        char*  class;
+        IV     dim;
     INIT:
-        I32  i;
-        SV*  self;
-        SV*  zero;
-        AV*  my_array;
-        HV*  stash;
-
+        IV     i;
+        SV*    self;
+        SV*    zero;
+        AV*    my_array;
+        HV*    stash;
     CODE:
         /* create the object and populate it */
         my_array = newAV();
-        for ( i=0; i<dimension; i++ ) {
+        for ( i=0; i<dim; i++ ) {
             zero = newSViv(0);
             av_push(my_array, zero);
         }
@@ -99,7 +94,6 @@ new_zeroes( class, dimension )
         stash = gv_stashpv( class, TRUE );
         sv_bless( (SV*)self, stash );
         RETVAL = self;
-
     OUTPUT:
         RETVAL
 
@@ -112,15 +106,13 @@ new_zeroes( class, dimension )
 #
 SV*
 copy( vec, ... )
-        SV* vec;
-
+        SV*  vec;
     INIT:
-        I32  val, i;
+        IV   val, i;
         SV*  self;
         AV*  my_array;
         AV*  vec_array;
         HV*  stash;
-
     CODE:
         vec_array = (AV*)SvRV(vec);
 
@@ -136,7 +128,6 @@ copy( vec, ... )
         stash = SvSTASH( (SV*)vec_array );
         sv_bless( (SV*)self, stash );
         RETVAL = self;
-
     OUTPUT:
         RETVAL
 
@@ -150,31 +141,28 @@ copy( vec, ... )
 #
 # Return the number of dimensions, an integer.
 #
-I32
+IV
 get_dims( self )
-        AV* self;
-
+        AV*  self;
     CODE:
         RETVAL = av_len(self) + 1;
-
     OUTPUT:
         RETVAL
 
+
 #
 # my $val = $vec->get_component( $index );
 #
 # Return the value for dimension $index.
 #
-I32
+IV
 get_component( self, index )
-        AV* self;
-        I32 index;
-
+        AV*  self;
+        IV   index;
     CODE:
         if ( index < 0 || index > av_len(self) )
             croak( "No such dimension!" );
         RETVAL = SvIV( *av_fetch(self, index, 0) );
-
     OUTPUT:
         RETVAL
 
@@ -186,12 +174,10 @@ get_component( self, index )
 #
 void
 get_all_components( self )
-        SV* self;
-
+        SV*  self;
     PREINIT:
-        IV  dim, i, val;
-        AV* my_array;
-
+        IV   dim, i, val;
+        AV*  my_array;
     PPCODE:
         /* fetch the underlying array of the object */
         my_array = (AV*)SvRV(self);
@@ -213,7 +199,7 @@ get_all_components( self )
 #
 void
 clear( self )
-        SV* self
+        SV*  self;
     INIT:
         IV   dim, i, zero;
         AV*  my_array;
@@ -239,17 +225,13 @@ clear( self )
 #
 SV*
 _add_inplace( v1, v2, variant )
-        SV* v1;
-        SV* v2;
-        SV* variant;
-
+        SV*  v1;
+        SV*  v2;
+        SV*  variant;
     INIT:
-        I32 dimv1, dimv2;
-        I32 i;
-        I32 val1, val2;
-        AV* v1_array;
-        AV* v2_array;
-
+        IV   dimv1, dimv2, i, val1, val2;
+        AV*  v1_array;
+        AV*  v2_array;
     CODE:
         /* fetch the underlying array of the object */
         v1_array = (AV*)SvRV(v1);
@@ -266,7 +248,6 @@ _add_inplace( v1, v2, variant )
             val2 = SvIV( *av_fetch(v2_array, i, 0) );
             av_store( v1_array, i, newSViv(val1+val2) );
 	    }
-
     OUTPUT:
         v1
 
@@ -279,17 +260,13 @@ _add_inplace( v1, v2, variant )
 #
 SV*
 _substract_inplace( v1, v2, variant )
-        SV* v1;
-        SV* v2;
-        SV* variant;
-
+        SV*  v1;
+        SV*  v2;
+        SV*  variant;
     INIT:
-        I32 dimv1, dimv2;
-        I32 i;
-        I32 val1, val2;
-        AV* v1_array;
-        AV* v2_array;
-
+        IV   dimv1, dimv2, i, val1, val2;
+        AV*  v1_array;
+        AV*  v2_array;
     CODE:
         /* fetch the underlying array of the object */
         v1_array = (AV*)SvRV(v1);
@@ -306,7 +283,6 @@ _substract_inplace( v1, v2, variant )
             val2 = SvIV( *av_fetch(v2_array, i, 0) );
             av_store( v1_array, i, newSViv(val1-val2) );
 	    }
-
     OUTPUT:
         v1
 
@@ -320,17 +296,14 @@ _substract_inplace( v1, v2, variant )
 # Check whether the vectors both point at the same spot. Return 0 if they
 # do, 1 if they don't.
 #
-I32
+IV
 _compare( v1, v2, variant )
-        AV* v1;
-        AV* v2;
-        SV* variant;
+        AV*  v1;
+        AV*  v2;
+        SV*  variant;
 
     INIT:
-        I32 dimv1, dimv2;
-        I32 i;
-        I32 val1, val2;
-
+        IV   dimv1, dimv2, i, val1, val2;
     CODE:
         dimv1 = av_len(v1);
         dimv2 = av_len(v2);
@@ -348,7 +321,6 @@ _compare( v1, v2, variant )
                 break;
             }
         }
-
     OUTPUT:
         RETVAL
 
-- 
2.11.4.GIT