From 42ef788d7c15b837f9f1f9db1393d310f3dca395 Mon Sep 17 00:00:00 2001 From: gevaerts Date: Sat, 27 Mar 2010 19:41:37 +0000 Subject: [PATCH] Remove unnecessary (and incorrect) acks after stalling the control endpoint git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25359 a1c6a512-1295-4272-9138-f99709370657 --- firmware/usbstack/usb_core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/firmware/usbstack/usb_core.c b/firmware/usbstack/usb_core.c index a5865da9f..b7334879f 100644 --- a/firmware/usbstack/usb_core.c +++ b/firmware/usbstack/usb_core.c @@ -507,14 +507,6 @@ static void allocate_interfaces_and_endpoints(void) usb_core_num_interfaces = interface; } -static int usb_core_ack_control(struct usb_ctrlrequest* req) -{ - if (req->bRequestType & USB_DIR_IN) - return usb_drv_recv(EP_CONTROL,NULL,0); - else - return usb_drv_send(EP_CONTROL,NULL,0); -} - static void control_request_handler_drivers(struct usb_ctrlrequest* req) { @@ -536,7 +528,6 @@ static void control_request_handler_drivers(struct usb_ctrlrequest* req) /* nope. flag error */ logf("bad req:desc %d:%d", req->bRequest, req->wValue>>8); usb_drv_stall(EP_CONTROL, true, true); - usb_core_ack_control(req); } } @@ -744,7 +735,6 @@ static void request_handler_endoint_drivers(struct usb_ctrlrequest* req) /* nope. flag error */ logf("usb bad req %d",req->bRequest); usb_drv_stall(EP_CONTROL,true,true); - usb_core_ack_control(req); } } -- 2.11.4.GIT