From 0f3e2f50b5dff505410b4cbf6b98fc008b1de42f Mon Sep 17 00:00:00 2001 From: kugel Date: Sun, 15 Nov 2009 20:45:50 +0000 Subject: [PATCH] Partly revert r23625 (the TIMEOUT_NOBLOCK change), and add a comment explaining why (or trying to, at least). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23637 a1c6a512-1295-4272-9138-f99709370657 --- apps/gui/wps.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/apps/gui/wps.c b/apps/gui/wps.c index cc6bd60ef..9236f9f6e 100644 --- a/apps/gui/wps.c +++ b/apps/gui/wps.c @@ -770,9 +770,12 @@ long gui_wps_show(void) -> no additional screen updates needed */ else #endif - { + { /* 1 is the minimum timeout which lets other threads run. + * audio thread (apprently) needs to run before displaying the wps + * or bad things happen with regards to cuesheet + * (probably a race condition, on sh at least) */ button = get_action(CONTEXT_WPS|ALLOW_SOFTLOCK, - restore ? TIMEOUT_NOBLOCK : HZ/5); + restore ? 1 : HZ/5); } /* Exit if audio has stopped playing. This happens e.g. at end of -- 2.11.4.GIT