| commit | a0a0e057c0620a49246d0b5c55a6013b1f664780 | |
| author | Marcel de Rooy <m.de.rooy@rijksmuseum.nl> | |
| Wed, 13 Jul 2016 09:59:28 +0000 (13 11:59 +0200) | ||
| committer | Frédéric Demians <f.demians@tamil.fr> | |
| Mon, 1 Aug 2016 09:54:02 +0000 (1 11:54 +0200) | ||
| tree | d58a4205d68c70826b3199f897acb4931c0229f1 | treesnapshot (tar.gz zip) |
| parent | aee5ba06949551ec789e5d95a41f8f224b2ae295 | commitdiff |
Bug 15006: [QA Follow-up] Only handle login requests in raw_transport
Although mainly hypothetical, it would still be possible to get
response from the server for an acs resend request. (This exception
is allowed in MsgType::handle.)
I also noticed that the response may well be a message from an older
session still.
This patch just removes that exception by only passing login requests
to sub handle in the raw_transport loop.
Test plan:
[1] Verify normal login procedure for raw.
[2] Check a few acs resend requests in raw. They should terminate without
a response.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit e465d1aa4b16d7392950b2b682f99eb0c58c1ffd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Although mainly hypothetical, it would still be possible to get
response from the server for an acs resend request. (This exception
is allowed in MsgType::handle.)
I also noticed that the response may well be a message from an older
session still.
This patch just removes that exception by only passing login requests
to sub handle in the raw_transport loop.
Test plan:
[1] Verify normal login procedure for raw.
[2] Check a few acs resend requests in raw. They should terminate without
a response.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit e465d1aa4b16d7392950b2b682f99eb0c58c1ffd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
| C4/SIP/SIPServer.pm | diffblobblamehistory |