Bug 25898: Prohibit indirect object notation
commit96cc447045f3f1d3702a3c69b36f596d88f38eda
authorJulian Maurice <julian.maurice@biblibre.com>
Mon, 29 Jun 2020 17:07:54 +0000 (29 21:07 +0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 15 Oct 2020 10:56:30 +0000 (15 12:56 +0200)
tree85b3647e2b770dd9040f0f8ffe480abb19cc54e8
parent3e2b6b929923e5e616d2520bb34f0f0838cd82d3
Bug 25898: Prohibit indirect object notation

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
509 files changed:
.perlcriticrc
C4/Auth.pm
C4/AuthoritiesMarc.pm
C4/Breeding.pm
C4/Context.pm
C4/InstallAuth.pm
C4/Languages.pm
C4/Record.pm
C4/SIP/Sip/Configuration.pm
C4/SIP/t/SIPtest.pm
C4/SIP/xmlparse.pl
C4/Search.pm
C4/Service.pm
Koha/Illrequest/Logger.pm
Koha/OAI/Server/DeletedRecord.pm
Koha/OAI/Server/GetRecord.pm
Koha/OAI/Server/ListBase.pm
Koha/OAI/Server/ListIdentifiers.pm
Koha/OAI/Server/ListRecords.pm
Koha/OAI/Server/ListSets.pm
Koha/OAI/Server/Record.pm
Koha/OAI/Server/Repository.pm
Koha/Patron/Discharge.pm
Koha/SuggestionEngine/Plugin/ExplodedTerms.pm
Koha/pdfformat/layout2pages.pm
Koha/pdfformat/layout2pagesde.pm
Koha/pdfformat/layout3pages.pm
Koha/pdfformat/layout3pagesfr.pm
about.pl
acqui/add_user_search.pl
acqui/addorder.pl
acqui/addorderiso2709.pl
acqui/ajax-getauthvaluedropbox.pl
acqui/basket.pl
acqui/basketgroup.pl
acqui/basketheader.pl
acqui/cancelorder.pl
acqui/check_budget_total.pl
acqui/check_uniqueness.pl
acqui/duplicate_orders.pl
acqui/finishreceive.pl
acqui/histsearch.pl
acqui/invoice-files.pl
acqui/invoice.pl
acqui/lateorders-export.pl
acqui/lateorders.pl
acqui/modordernotes.pl
acqui/neworderempty.pl
acqui/newordersubscription.pl
acqui/newordersuggestion.pl
acqui/ordered.pl
acqui/orderreceive.pl
acqui/parcel.pl
acqui/showorder.pl
acqui/spent.pl
acqui/transferorder.pl
acqui/uncertainprice.pl
acqui/updatesupplier.pl
acqui/z3950_search.pl
admin/add_user_search.pl
admin/additional-fields.pl
admin/admin-home.pl
admin/adveditorshortcuts.pl
admin/aqbudgetperiods.pl
admin/aqbudgets.pl
admin/aqcontract.pl
admin/aqplan.pl
admin/audio_alerts.pl
admin/auth_subfields_structure.pl
admin/auth_tag_structure.pl
admin/authorised_values.pl
admin/authtypes.pl
admin/biblio_framework.pl
admin/branch_transfer_limits.pl
admin/categories.pl
admin/check_budget_parent.pl
admin/check_parent_total.pl
admin/checkmarc.pl
admin/cities.pl
admin/classsources.pl
admin/clone-rules.pl
admin/columns_settings.pl
admin/credit_types.pl
admin/debit_types.pl
admin/desks.pl
admin/didyoumean.pl
admin/import_export_framework.pl
admin/item_circulation_alerts.pl
admin/items_search_field.pl
admin/items_search_fields.pl
admin/itemtypes.pl
admin/koha2marclinks.pl
admin/library_groups.pl
admin/localization.pl
admin/marc_subfields_structure.pl
admin/marctagstructure.pl
admin/matching-rules.pl
admin/oai_set_mappings.pl
admin/oai_sets.pl
admin/patron-attr-types.pl
admin/preferences.pl
admin/searchengine/elasticsearch/mappings.pl
admin/share_content.pl
admin/sms_providers.pl
admin/sru_modmapping.pl
admin/systempreferences.pl
admin/transport-cost-matrix.pl
admin/usage_statistics.pl
admin/z3950servers.pl
authorities/auth_finder.pl
authorities/authorities-home.pl
authorities/authorities.pl
authorities/blinddetail-biblio-search.pl
authorities/detail-biblio-search.pl
authorities/detail.pl
authorities/export.pl
authorities/merge.pl
authorities/ysearch.pl
basket/basket.pl
basket/downloadcart.pl
catalogue/ISBDdetail.pl
catalogue/MARCdetail.pl
catalogue/export.pl
catalogue/getitem-ajax.pl
catalogue/image.pl
catalogue/imageviewer.pl
catalogue/issuehistory.pl
catalogue/item-export.pl
catalogue/itemsearch.pl
catalogue/labeledMARCdetail.pl
catalogue/moredetail.pl
catalogue/search-history.pl
catalogue/search.pl
catalogue/showmarc.pl
catalogue/stockrotation.pl
catalogue/updateitem.pl
cataloguing/addbiblio.pl
cataloguing/addbooks.pl
cataloguing/additem.pl
cataloguing/merge.pl
cataloguing/plugin_launcher.pl
cataloguing/value_builder/unimarc_field_210c.pl
cataloguing/value_builder/unimarc_field_4XX.pl
cataloguing/ysearch.pl
cataloguing/z3950_auth_search.pl
cataloguing/z3950_search.pl
changelanguage.pl
circ/add_message.pl
circ/article-request-slip.pl
circ/article-requests.pl
circ/bookcount.pl
circ/branchoverdues.pl
circ/branchtransfers.pl
circ/checkout-notes.pl
circ/circulation-home.pl
circ/circulation.pl
circ/del_message.pl
circ/hold-transfer-slip.pl
circ/offline-mf.pl
circ/offline.pl
circ/on-site_checkouts.pl
circ/overdue.pl
circ/pendingreserves.pl
circ/renew.pl
circ/request-article.pl
circ/reserveratios.pl
circ/returns.pl
circ/transfer-slip.pl
circ/transferstoreceive.pl
circ/view_holdsqueue.pl
circ/waitingreserves.pl
circ/ypattrodue-attr-search-authvalue.pl
circ/ysearch.pl
clubs/club-enrollments.pl
clubs/clubs-add-modify.pl
clubs/clubs.pl
clubs/patron-clubs-tab.pl
clubs/patron-enroll.pl
clubs/templates-add-modify.pl
course_reserves/add_items.pl
course_reserves/batch_add_items.pl
course_reserves/course-details.pl
course_reserves/course-reserves.pl
course_reserves/course.pl
course_reserves/mod_course.pl
docs/CAS/CASProxy/examples/koha_webservice.pl
docs/CAS/CASProxy/examples/proxy_cas.pl
docs/CAS/CASProxy/examples/proxy_cas_callback.pl
docs/CAS/CASProxy/examples/proxy_cas_data.pl
help.pl
installer/install.pl
installer/onboarding.pl
labels/label-create-csv.pl
labels/label-create-pdf.pl
labels/label-create-xml.pl
labels/label-edit-batch.pl
labels/label-edit-layout.pl
labels/label-edit-profile.pl
labels/label-edit-range.pl
labels/label-edit-template.pl
labels/label-home.pl
labels/label-item-search.pl
labels/label-manage.pl
labels/label-print.pl
labels/spinelabel-home.pl
labels/spinelabel-print.pl
mainpage.pl
members/accountline-details.pl
members/apikeys.pl
members/boraccount.pl
members/deletemem.pl
members/discharge.pl
members/discharges.pl
members/guarantor_search.pl
members/ill-requests.pl
members/mancredit.pl
members/maninvoice.pl
members/member-flags.pl
members/member-password.pl
members/member.pl
members/memberentry.pl
members/members-home.pl
members/members-update-do.pl
members/members-update.pl
members/merge-patrons.pl
members/mod_debarment.pl
members/notices.pl
members/patronimage.pl
members/print_overdues.pl
members/printfeercpt.pl
members/printinvoice.pl
members/printslip.pl
members/purchase-suggestions.pl
members/routing-lists.pl
members/setstatus.pl
members/statistics.pl
members/update-child.pl
misc/batchImportMARCWithBiblionumbers.pl
misc/cronjobs/check-url.pl
misc/cronjobs/cloud-kw.pl
misc/cronjobs/gather_print_notices.pl
misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl
misc/migration_tools/ifla/update.pl
misc/translator/LangInstaller.pm
misc/translator/po2json
offline_circ/download.pl
opac/clubs/clubs-tab.pl
opac/clubs/enroll.pl
opac/errors/400.pl
opac/errors/401.pl
opac/errors/402.pl
opac/errors/403.pl
opac/errors/404.pl
opac/errors/500.pl
opac/external/overdrive/auth.pl
opac/ilsdi.pl
opac/maintenance.pl
opac/opac-account-pay-paypal-return.pl
opac/opac-account-pay-return.pl
opac/opac-account-pay.pl
opac/opac-account.pl
opac/opac-addbybiblionumber.pl
opac/opac-alert-subscribe.pl
opac/opac-article-request-cancel.pl
opac/opac-authorities-home.pl
opac/opac-authoritiesdetail.pl
opac/opac-basket.pl
opac/opac-blocked.pl
opac/opac-browse.pl
opac/opac-browser.pl
opac/opac-changelanguage.pl
opac/opac-course-details.pl
opac/opac-course-reserves.pl
opac/opac-discharge.pl
opac/opac-downloadshelf.pl
opac/opac-ics.pl
opac/opac-idref.pl
opac/opac-illrequests.pl
opac/opac-image.pl
opac/opac-imageviewer.pl
opac/opac-issue-note.pl
opac/opac-main.pl
opac/opac-memberentry.pl
opac/opac-modrequest-suspend.pl
opac/opac-modrequest.pl
opac/opac-news-rss.pl
opac/opac-overdrive-search.pl
opac/opac-passwd.pl
opac/opac-password-recovery.pl
opac/opac-patron-consent.pl
opac/opac-patron-image.pl
opac/opac-privacy.pl
opac/opac-readingrecord.pl
opac/opac-recordedbooks-search.pl
opac/opac-registration-verify.pl
opac/opac-renew.pl
opac/opac-reportproblem.pl
opac/opac-request-article.pl
opac/opac-reserve.pl
opac/opac-restrictedpage.pl
opac/opac-review.pl
opac/opac-routing-lists.pl
opac/opac-search-history.pl
opac/opac-search.pl
opac/opac-sendshelf.pl
opac/opac-serial-issues.pl
opac/opac-shareshelf.pl
opac/opac-shelves.pl
opac/opac-showmarc.pl
opac/opac-showreviews.pl
opac/opac-suggestions.pl
opac/opac-tags_subject.pl
opac/opac-topissues.pl
opac/opac-user.pl
opac/sci/sci-main.pl
opac/sco/help.pl
opac/sco/printslip.pl
opac/sco/sco-main.pl
opac/svc/checkout_notes
opac/svc/club/cancel_enrollment
opac/svc/club/enroll
opac/svc/overdrive
opac/svc/overdrive_proxy
opac/svc/recordedbooks
opac/svc/shelfbrowser.pl
opac/svc/suggestion
opac/tracklinks.pl
patron_lists/add-modify.pl
patron_lists/delete.pl
patron_lists/list.pl
patron_lists/lists.pl
patron_lists/patrons.pl
patroncards/add_user_search.pl
patroncards/create-pdf.pl
patroncards/edit-batch.pl
patroncards/edit-layout.pl
patroncards/edit-profile.pl
patroncards/edit-template.pl
patroncards/home.pl
patroncards/manage.pl
patroncards/print.pl
plugins/plugins-enable.pl
plugins/plugins-home.pl
plugins/plugins-uninstall.pl
plugins/plugins-upload.pl
plugins/run.pl
reports/acquisitions_stats.pl
reports/bor_issues_top.pl
reports/borrowers_out.pl
reports/borrowers_stats.pl
reports/cash_register_stats.pl
reports/cat_issues_top.pl
reports/catalogue_out.pl
reports/catalogue_stats.pl
reports/dictionary.pl
reports/guided_reports.pl
reports/issues_avg_stats.pl
reports/itemslost.pl
reports/manager.pl
reports/orders_by_fund.pl
reports/reports-home.pl
reports/reserves_stats.pl
reports/serials_stats.pl
reserve/modrequest.pl
reserve/modrequest_suspendall.pl
reserve/request.pl
reviews/reviewswaiting.pl
rotating_collections/addItems.pl
rotating_collections/editCollections.pl
rotating_collections/rotatingCollections.pl
rotating_collections/transferCollection.pl
serials/acqui-search-result.pl
serials/acqui-search.pl
serials/add_user_search.pl
serials/checkexpiration.pl
serials/create-numberpattern.pl
serials/lateissues-export.pl
serials/routing-preview.pl
serials/routing.pl
serials/serials-collection.pl
serials/serials-home.pl
serials/serials-search.pl
serials/showpredictionpattern.pl
serials/subscription-batchedit.pl
serials/subscription-bib-search.pl
serials/subscription-detail.pl
serials/subscription-frequencies.pl
serials/subscription-frequency.pl
serials/subscription-history.pl
serials/subscription-numberpattern.pl
serials/subscription-numberpatterns.pl
serials/subscription-renew.pl
serials/viewalerts.pl
services/itemrecorddisplay.pl
suggestion/add_user_search.pl
suggestion/suggester_search.pl
svc/article_request
svc/authentication
svc/barcode
svc/bib
svc/bib_framework
svc/bib_profile
svc/checkin
svc/checkout_notes
svc/checkouts
svc/club/cancel_enrollment
svc/club/delete
svc/club/enroll
svc/club/template/delete
svc/cover_images
svc/creator_batches
svc/hold/resume
svc/hold/suspend
svc/holds
svc/import_bib
svc/letters/preview
svc/mana/increment
svc/mana/search
svc/mana/share
svc/mana/use
svc/members/add_to_list
svc/members/search
svc/new_bib
svc/problem_reports
svc/renew
svc/return_claims
svc/virtualshelves/search
t/Auth_with_shibboleth.t
t/Calendar.t
t/Context.t
t/DateUtils.t
t/Koha_MetadataRecord.t
t/Koha_Template_Plugin_Koha.t
t/Languages.t
t/Output_JSONStream.t
t/Search/History.t
t/SuggestionEngine_AuthorityFile.t
t/db_dependent/00-strict.t
t/db_dependent/Accounts.t
t/db_dependent/Acquisition.t
t/db_dependent/Auth.t
t/db_dependent/Auth_with_cas.t
t/db_dependent/AuthoritiesMarc.t
t/db_dependent/BackgroundJob.t
t/db_dependent/Biblio.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/CheckIfIssuedToPatron.t
t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
t/db_dependent/Creators/Lib.t
t/db_dependent/FrameworkPlugin.t
t/db_dependent/ILSDI_Services.t
t/db_dependent/Items.t
t/db_dependent/Koha/Account.t
t/db_dependent/Koha/Account/Line.t
t/db_dependent/Koha/Patron/Messages.t
t/db_dependent/Koha/Patrons.t
t/db_dependent/Koha/Z3950Responder/GenericSession.t
t/db_dependent/Koha/Z3950Responder/ZebraSession.t
t/db_dependent/Members/GetAllIssues.t
t/db_dependent/Members/IssueSlip.t
t/db_dependent/Record.t
t/db_dependent/RecordProcessor_EmbedSeeFromHeadings.t
t/db_dependent/Reserves/GetReserveFee.t
t/db_dependent/Search.t
t/db_dependent/Search/History.t
t/db_dependent/Serials.t
t/db_dependent/SuggestionEngine_ExplodedTerms.t
t/db_dependent/TablesSettings.t
t/db_dependent/Template/Plugin/KohaDates.t
t/db_dependent/XISBN.t
t/db_dependent/api/v1/checkouts.t
t/lib/Mocks.pm
tools/access_files.pl
tools/ajax-inventory.pl
tools/automatic_item_modification_by_age.pl
tools/batchMod.pl
tools/batch_delete_records.pl
tools/batch_extend_due_dates.pl
tools/batch_record_modification.pl
tools/batch_records_ajax.pl
tools/cleanborrowers.pl
tools/copy-holidays.pl
tools/csv-profiles.pl
tools/exceptionHolidays.pl
tools/export.pl
tools/holidays.pl
tools/koha-news.pl
tools/letter.pl
tools/manage-marc-import.pl
tools/marc_modification_templates.pl
tools/modborrowers.pl
tools/newHolidays.pl
tools/overduerules.pl
tools/picture-upload.pl
tools/problem-reports.pl
tools/quotes-upload.pl
tools/quotes.pl
tools/quotes/quotes-upload_ajax.pl
tools/scheduler.pl
tools/showdiffmarc.pl
tools/stage-marc-import.pl
tools/stockrotation.pl
tools/tools-home.pl
tools/upload-cover-image.pl
tools/viewlog.pl
virtualshelves/addbybiblionumber.pl
virtualshelves/downloadshelf.pl
virtualshelves/shelves.pl
xt/author/valid-templates.t