| commit | 49253ace12e6cd1350680f3b9b3ee3f904067767 | |
| author | Marcel de Rooy <m.de.rooy@rijksmuseum.nl> | |
| Fri, 19 May 2017 10:22:03 +0000 (19 12:22 +0200) | ||
| committer | Kyle M Hall <kyle@bywatersolutions.com> | |
| Fri, 19 May 2017 14:35:48 +0000 (19 10:35 -0400) | ||
| tree | d0579a843748c7126ac9759ec55e47f992786e62 | treesnapshot (tar.gz zip) |
| parent | f2dee024a7e503132fd0c82a4f47d8c5353613e4 | commitdiff |
Bug 18552: [QA Follow-up] Resolve warnings
Like:
Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem is functions returning undef in list context (in this case
housebound_role).
No need to call Patrons::find a second time.
Note: The call of GetDebarments in the first patch suffered from this too.
It is in a fine place now too. But strictly speaking, should not have been
moved.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Like:
Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem is functions returning undef in list context (in this case
housebound_role).
No need to call Patrons::find a second time.
Note: The call of GetDebarments in the first patch suffered from this too.
It is in a fine place now too. But strictly speaking, should not have been
moved.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
| members/moremember.pl | diffblobblamehistory |