From 422316ac6ab849898ab6e495c2121bed3d862f58 Mon Sep 17 00:00:00 2001 From: Sven Verdoolaege Date: Fri, 10 Oct 2014 11:42:51 +0200 Subject: [PATCH] isl_tab.c: perform_undo_var: propagate errors of drop_row and drop_col By design, we should only be dropping the final row or the final column. However, if something should go wrong, we should propagate the error to the caller. Signed-off-by: Sven Verdoolaege --- isl_tab.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/isl_tab.c b/isl_tab.c index 5050bfbc..1aea6ff6 100644 --- a/isl_tab.c +++ b/isl_tab.c @@ -3109,8 +3109,7 @@ static int perform_undo_var(struct isl_tab *tab, struct isl_tab_undo *undo) case isl_tab_undo_allocate: if (undo->u.var_index >= 0) { isl_assert(tab->mat->ctx, !var->is_row, return -1); - drop_col(tab, var->index); - break; + return drop_col(tab, var->index); } if (!var->is_row) { if (!max_is_manifestly_unbounded(tab, var)) { @@ -3123,8 +3122,7 @@ static int perform_undo_var(struct isl_tab *tab, struct isl_tab_undo *undo) if (to_row(tab, var, 0) < 0) return -1; } - drop_row(tab, var->index); - break; + return drop_row(tab, var->index); case isl_tab_undo_relax: return unrelax(tab, var); case isl_tab_undo_unrestrict: -- 2.11.4.GIT