| commit | 595ae8ecd219bf46111d5f896bcc534a3209e303 | |
| author | Tobias Grosser <tobias@grosser.es> | |
| Fri, 6 Jan 2017 14:26:30 +0000 (6 15:26 +0100) | ||
| committer | Sven Verdoolaege <sven.verdoolaege@gmail.com> | |
| Fri, 8 Sep 2017 10:10:53 +0000 (8 12:10 +0200) | ||
| tree | bcc0587524385fc5e44cb14c9f87bab7884cb79b | treesnapshot (tar.gz zip) |
| parent | 4a2dd2b7b5de8a9aeb1d8e795ad4fa58a0906589 | commitdiff |
python: remove redundant is_string_type
In commit 72f7994 (python interface: support 'char *' and 'const *'
return types, Thu Jun 30 16:22:34 2016), the is_string_type() method was
added accidentally despite is_string() already providing the very
functionality. Even worse, is_string_type() has a bug where a "char"
interpreted as boolean true and it also contains a seemingly unnecessary
call to isFunctionType(). Remove the redundant function definition and
switch the two users to is_string().
This change does not change the output of isl.py.
Reported-by: Sven Verdoolaege <skimo@kotnet.org>
Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
In commit 72f7994 (python interface: support 'char *' and 'const *'
return types, Thu Jun 30 16:22:34 2016), the is_string_type() method was
added accidentally despite is_string() already providing the very
functionality. Even worse, is_string_type() has a bug where a "char"
interpreted as boolean true and it also contains a seemingly unnecessary
call to isFunctionType(). Remove the redundant function definition and
switch the two users to is_string().
This change does not change the output of isl.py.
Reported-by: Sven Verdoolaege <skimo@kotnet.org>
Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
| interface/python.cc | diffblobblamehistory |