Fixed several clang-tidy issues
commitf4903a7b46d4b92636c364fdd31ecbf8230e69a6
authorMark Abraham <mark.j.abraham@gmail.com>
Tue, 28 Apr 2020 18:08:18 +0000 (28 20:08 +0200)
committerArtem Zhmurov <zhmurov@gmail.com>
Wed, 29 Apr 2020 06:23:47 +0000 (29 06:23 +0000)
tree37fb0334f55ee4e4ec539e113bc0c79cba5538e0
parent0cf283bc63573757d32295c09fd76fe2f316f21b
Fixed several clang-tidy issues

A static variable was vulnerable to static-init-order-fiasco.  Tests
will still perform OK even with constructing the default value
multiple times, so converted to a getter.

Closes #3498
src/gromacs/analysisdata/tests/datatest.cpp
src/gromacs/listed_forces/gpubonded.h
src/programs/mdrun/tests/energycomparison.cpp
src/programs/mdrun/tests/energycomparison.h
src/programs/mdrun/tests/periodicactions.cpp