Move responsibility for PME reduction to its module
commitd181859fb5e1da52930a0c05daa9876b65227a63
authorMark Abraham <mark.j.abraham@gmail.com>
Wed, 28 Nov 2018 11:46:15 +0000 (28 12:46 +0100)
committerPaul Bauer <paul.bauer.q@gmail.com>
Mon, 3 Dec 2018 15:53:27 +0000 (3 16:53 +0100)
treea3abbba0aa575d533c387ec8a082abce119de726
parentad77000af9af50267c9e22891832658e6fdeafa3
Move responsibility for PME reduction to its module

We no longer need temporary energy and virial variables that gcc 7 and
8 warn about in release mode. Earlier efforts to avoid these warnings
made pme.h depend on config.h, which is not desirable.

This made possible minor simplifications to testing code.

Noted some TODOs and added some comments. Removed a completed TODO
that had been left behind.

Fixes #2503
Refs #2863

Change-Id: I9a6c5b12ef5c27bd003d3ab9eeeaa75e9574b2dc
14 files changed:
src/gromacs/ewald/pme-gpu-internal.cpp
src/gromacs/ewald/pme-gpu-internal.h
src/gromacs/ewald/pme-gpu-types-host.h
src/gromacs/ewald/pme-gpu.cpp
src/gromacs/ewald/pme-only.cpp
src/gromacs/ewald/pme-solve.cpp
src/gromacs/ewald/pme-solve.h
src/gromacs/ewald/pme.cpp
src/gromacs/ewald/pme.h
src/gromacs/ewald/tests/pmesolvetest.cpp
src/gromacs/ewald/tests/pmetestcommon.cpp
src/gromacs/ewald/tests/pmetestcommon.h
src/gromacs/mdlib/force.cpp
src/gromacs/mdlib/sim_util.cpp