| commit | 583b76dfbbc751cc48fb776eacae6e3002118be1 | |
| author | David van der Spoel <spoel@xray.bmc.uu.se> | |
| Wed, 19 Jul 2017 05:36:31 +0000 (19 07:36 +0200) | ||
| committer | David van der Spoel <davidvanderspoel@gmail.com> | |
| Wed, 19 Jul 2017 10:00:25 +0000 (19 12:00 +0200) | ||
| tree | a423ba2164ae9fd26a451d905bd2b4f3ef10158b | treesnapshot (tar.gz zip) |
| parent | 2cce9cb6d1ee3a72b866332eabd194dfed3cf8bd | commitdiff |
Fixed test-order dependency in gmxpreprocess tests.
Due to the use of static variable in genconf.cpp and
solvate.cpp, used for initializing command-line args
the result of the tests were dependent on the order of
execution. The reason is that static variables set in one
of the test runs are "inherited" by the next run. A
particular example is a randum number seed, which when 0
is set to a random seed, but just the first time around. This
is obviously not a good idea when aiming for reproducability.
Part of #2113.
Change-Id: I8bd8d36c75dcd20824e7f3db7268512387cd04ca
Due to the use of static variable in genconf.cpp and
solvate.cpp, used for initializing command-line args
the result of the tests were dependent on the order of
execution. The reason is that static variables set in one
of the test runs are "inherited" by the next run. A
particular example is a randum number seed, which when 0
is set to a random seed, but just the first time around. This
is obviously not a good idea when aiming for reproducability.
Part of #2113.
Change-Id: I8bd8d36c75dcd20824e7f3db7268512387cd04ca