| commit | 55875598f734797804da23c499ba79ca242ef59d | |
| author | Protobuf Team Bot <protobuf-github-bot@google.com> | |
| Wed, 24 Apr 2024 17:39:37 +0000 (24 10:39 -0700) | ||
| committer | Copybara-Service <copybara-worker@google.com> | |
| Wed, 24 Apr 2024 17:41:46 +0000 (24 10:41 -0700) | ||
| tree | ebe825a2c7b7e6b9576116f8ed0c4d5c30339768 | treesnapshot (tar.gz zip) |
| parent | 849b975e5fce3d181aea692b412826f48c38e087 | commitdiff |
Add a collision-avoidance behavior to the Rust Proto codegen.
The intent is to avoid codegen issues for simple cases where a message of the shape:
message M {
int32 x = 3
string set_x = 8;
}
Which would otherwise break due to the first field having a setter whose name collides with the second field's getter.
By seeing that 'set_x' matches another field with a common accessor prefixed, it will generate all accessors for that field as though it was named `set_x_8`.
This does not avoid all possible collisions, but should mitigate the vast majority of situations of an accidental collision.
PiperOrigin-RevId: 627776907
The intent is to avoid codegen issues for simple cases where a message of the shape:
message M {
int32 x = 3
string set_x = 8;
}
Which would otherwise break due to the first field having a setter whose name collides with the second field's getter.
By seeing that 'set_x' matches another field with a common accessor prefixed, it will generate all accessors for that field as though it was named `set_x_8`.
This does not avoid all possible collisions, but should mitigate the vast majority of situations of an accidental collision.
PiperOrigin-RevId: 627776907
12 files changed: