| commit | e865dcbb7b3319fc6b03939edae0769154051d84 | |
| author | Szabolcs Nagy <szabolcs.nagy@arm.com> | |
| Wed, 17 Feb 2021 10:39:37 +0000 (17 10:39 +0000) | ||
| committer | Szabolcs Nagy <szabolcs.nagy@arm.com> | |
| Fri, 26 Mar 2021 11:03:06 +0000 (26 11:03 +0000) | ||
| tree | 5cead9869063b4cdfa8ed997d138128f9961af19 | treesnapshot (tar.gz zip) |
| parent | b9b85be6ea97c126ad6f69f84f056bad6756ee5c | commitdiff |
malloc: Ensure the generic mtag hooks are not used
Use inline functions instead of macros, because macros can cause unused
variable warnings and type conversion issues. We assume these functions
may appear in the code but only in dead code paths (hidden by a runtime
check), so it's important that they can compile with correct types, but
if they are actually used that should be an error.
Currently the hooks are only used when USE_MTAG is true which only
happens on aarch64 and then the aarch64 specific code is used not this
generic header. However followup refactoring will allow the hooks to
be used with !USE_MTAG.
Note: the const qualifier in the comment was wrong: changing tags is a
write operation.
Reviewed-by: DJ Delorie <dj@redhat.com>
Use inline functions instead of macros, because macros can cause unused
variable warnings and type conversion issues. We assume these functions
may appear in the code but only in dead code paths (hidden by a runtime
check), so it's important that they can compile with correct types, but
if they are actually used that should be an error.
Currently the hooks are only used when USE_MTAG is true which only
happens on aarch64 and then the aarch64 specific code is used not this
generic header. However followup refactoring will allow the hooks to
be used with !USE_MTAG.
Note: the const qualifier in the comment was wrong: changing tags is a
write operation.
Reviewed-by: DJ Delorie <dj@redhat.com>
| sysdeps/generic/libc-mtag.h | diffblobblamehistory |