| commit | e3217c7fd9e67aa2d53700bb1da9a966e73b9684 | |
| author | Siddhesh Poyarekar <siddhesh@sourceware.org> | |
| Wed, 9 Jun 2021 19:11:35 +0000 (10 00:41 +0530) | ||
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | |
| Wed, 23 Jun 2021 03:24:13 +0000 (23 08:54 +0530) | ||
| tree | 92ce340ce752510268401f64d215cdd14c0f1769 | treesnapshot (tar.gz zip) |
| parent | e8d52b64a54ba9ed7778ca9ce1f084eb5808f8d1 | commitdiff |
iconv: Remove alloca use in gconv-modules configuration parsing
The alloca sizes ought to be constrained to PATH_MAX, but replace them
with dynamic allocation to be safe. A static PATH_MAX array would
have worked too but Hurd does not have PATH_MAX and the code path is
not hot enough to micro-optimise this allocation. Revisit if any of
those realities change.
Reviewed-by: DJ Delorie <dj@redhat.com>
The alloca sizes ought to be constrained to PATH_MAX, but replace them
with dynamic allocation to be safe. A static PATH_MAX array would
have worked too but Hurd does not have PATH_MAX and the code path is
not hot enough to micro-optimise this allocation. Revisit if any of
those realities change.
Reviewed-by: DJ Delorie <dj@redhat.com>
| iconv/gconv_conf.c | diffblobblamehistory | |
| iconv/iconvconfig.c | diffblobblamehistory |