| commit | 8ae909a533b12221c3fd0c2331b13d99d9790718 | |
| author | Szabolcs Nagy <szabolcs.nagy@arm.com> | |
| Thu, 11 Mar 2021 14:09:56 +0000 (11 14:09 +0000) | ||
| committer | Szabolcs Nagy <szabolcs.nagy@arm.com> | |
| Fri, 26 Mar 2021 11:03:06 +0000 (26 11:03 +0000) | ||
| tree | 139dd8b6670e894ab1aa576cbbbf5b33d2484df7 | treesnapshot (tar.gz zip) |
| parent | 42cc96066b22ba065db11096c78881a55e45def4 | commitdiff |
malloc: Fix a potential realloc issue with memory tagging
At an _int_free call site in realloc the wrong size was used for tag
clearing: the chunk header of the next chunk was also cleared which
in practice may work, but logically wrong.
The tag clearing is moved before the memcpy to save a tag computation,
this avoids a chunk2mem. Another chunk2mem is removed because newmem
does not have to be recomputed. Whitespaces got fixed too.
Reviewed-by: DJ Delorie <dj@redhat.com>
At an _int_free call site in realloc the wrong size was used for tag
clearing: the chunk header of the next chunk was also cleared which
in practice may work, but logically wrong.
The tag clearing is moved before the memcpy to save a tag computation,
this avoids a chunk2mem. Another chunk2mem is removed because newmem
does not have to be recomputed. Whitespaces got fixed too.
Reviewed-by: DJ Delorie <dj@redhat.com>
| malloc/malloc.c | diffblobblamehistory |