Fix failure when CFLAGS contains -DNDEBUG (Bug 25251)
commit83fe078130f62c35fcceab7133fa4b1512925951
authorCarlos O'Donell <carlos@redhat.com>
Tue, 3 Dec 2019 20:42:24 +0000 (3 15:42 -0500)
committerCarlos O'Donell <carlos@redhat.com>
Tue, 10 Dec 2019 17:22:42 +0000 (10 12:22 -0500)
treeae73e40132b1bc9aa9b17d7a16ef572930f41e2d
parent0487ebed2278b20971af4cabf186fd3681adccf0
Fix failure when CFLAGS contains -DNDEBUG (Bug 25251)

Building tests with -DNDEBUG in CFLAGS, gcc 9.2.1 issues the following error:
tst-assert-c++.cc: In function ‘int do_test()’:
tst-assert-c++.cc:66:12: error: unused variable ‘value’ [-Werror=unused-variable]
   66 |     no_int value;
      |            ^~~~~
tst-assert-c++.cc:71:18: error: unused variable ‘value’ [-Werror=unused-variable]
   71 |     bool_and_int value;
      |                  ^~~~~

The assert has been disabled by building glibc with CFLAGS, CXXFLAGS,
and CPPFLAGS with -DNDEBUG which removes the assert and leaves the
value unused.

We never want the assert disabled because that's the point of the
test, so we undefine NDEBUG before including assert.h to ensure that
we get assert correctly defined.
assert/tst-assert-c++.cc