| commit | 61a87530108ec9181e1b18a9b727ec3cc3ba7532 | |
| author | Siddhesh Poyarekar <siddhesh@sourceware.org> | |
| Fri, 13 May 2022 04:31:47 +0000 (13 10:01 +0530) | ||
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | |
| Mon, 16 May 2022 14:40:08 +0000 (16 20:10 +0530) | ||
| tree | 087b65df424e96ee17fe07459dd92044ea03bdd9 | treesnapshot (tar.gz zip) |
| parent | 0b6c6750732483b4d59c2fcb45484079cd84157d | commitdiff |
fortify: Ensure that __glibc_fortify condition is a constant [BZ #29141]
The fix c8ee1c85 introduced a -1 check for object size without also
checking that object size is a constant. Because of this, the tree
optimizer passes in gcc fail to fold away one of the branches in
__glibc_fortify and trips on a spurious Wstringop-overflow. The warning
itself is incorrect and the branch does go away eventually in DCE in the
rtl passes in gcc, but the constant check is a helpful hint to simplify
code early, so add it in.
Resolves: BZ #29141
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
The fix c8ee1c85 introduced a -1 check for object size without also
checking that object size is a constant. Because of this, the tree
optimizer passes in gcc fail to fold away one of the branches in
__glibc_fortify and trips on a spurious Wstringop-overflow. The warning
itself is incorrect and the branch does go away eventually in DCE in the
rtl passes in gcc, but the constant check is a helpful hint to simplify
code early, so add it in.
Resolves: BZ #29141
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
| misc/sys/cdefs.h | diffblobblamehistory |