| commit | 5abcddd7949270998c6e8d99fdbbba821b664f8b | |
| author | Gabriel F. T. Gomes <gabriel@inconstante.eti.br> | |
| Thu, 21 Mar 2019 20:24:30 +0000 (21 17:24 -0300) | ||
| committer | Gabriel F. T. Gomes <gabriel@inconstante.eti.br> | |
| Thu, 21 Mar 2019 20:53:03 +0000 (21 17:53 -0300) | ||
| tree | 27501fa7879f5e6fef7b71ca7664e1fccb325d6f | treesnapshot (tar.gz zip) |
| parent | ac64195ccd4f320659fd0058bc7524c6fd0b37b4 | commitdiff |
Fix parentheses error in iconvconfig.c and ld-collate.c [BZ #24372]
When -Werror=parentheses is in use, iconvconfig.c builds fail with:
iconvconfig.c: In function ‘write_output’:
iconvconfig.c:1084:34: error: suggest parentheses around ‘+’ inside ‘>>’ [-Werror=parentheses]
hash_size = next_prime (nnames + nnames >> 1);
~~~~~~~^~~~~~~~
This patch adds parentheses to the expression. Not where suggested by
the compiler warning, but where it produces the expected result, i.e.:
where it has the effect of multiplying nnames by 1.5.
Likewise for elem_size in ld-collate.c.
Tested for powerpc64le.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
When -Werror=parentheses is in use, iconvconfig.c builds fail with:
iconvconfig.c: In function ‘write_output’:
iconvconfig.c:1084:34: error: suggest parentheses around ‘+’ inside ‘>>’ [-Werror=parentheses]
hash_size = next_prime (nnames + nnames >> 1);
~~~~~~~^~~~~~~~
This patch adds parentheses to the expression. Not where suggested by
the compiler warning, but where it produces the expected result, i.e.:
where it has the effect of multiplying nnames by 1.5.
Likewise for elem_size in ld-collate.c.
Tested for powerpc64le.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
| ChangeLog | diffblobblamehistory | |
| iconv/iconvconfig.c | diffblobblamehistory | |
| locale/programs/ld-collate.c | diffblobblamehistory |