riscv: Fix alignment-ignorant memcpy implementation
commit2149da36836bc32cd66359ca37bab5884af7e81f
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 5 Mar 2024 17:02:57 +0000 (5 14:02 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 12 Mar 2024 17:38:08 +0000 (12 14:38 -0300)
treea238d5f1dfcacdd229f9c4c3d479e8d304195116
parent2173173d57971d042c0ad4b281431ae127e9b5b8
riscv: Fix alignment-ignorant memcpy implementation

The memcpy optimization (commit 587a1290a1af7bee6db) has a series
of mistakes:

  - The implementation is wrong: the chunk size calculation is wrong
    leading to invalid memory access.

  - It adds ifunc supports as default, so --disable-multi-arch does
    not work as expected for riscv.

  - It mixes Linux files (memcpy ifunc selection which requires the
    vDSO/syscall mechanism)  with generic support (the memcpy
    optimization itself).

  - There is no __libc_ifunc_impl_list, which makes testing only
    check the selected implementation instead of all supported
    by the system.

This patch also simplifies the required bits to enable ifunc: there
is no need to memcopy.h; nor to add Linux-specific files.

The __memcpy_noalignment tail handling now uses a branchless strategy
similar to aarch64 (overlap 32-bits copies for sizes 4..7 and byte
copies for size 1..3).

Checked on riscv64 and riscv32 by explicitly enabling the function
on __libc_ifunc_impl_list on qemu-system.

Changes from v1:
* Implement the memcpy in assembly to correctly handle RISCV
  strict-alignment.
Reviewed-by: Evan Green <evan@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
sysdeps/riscv/memcpy_noalignment.S [deleted file]
sysdeps/riscv/multiarch/memcpy-generic.c [moved from sysdeps/unix/sysv/linux/riscv/memcpy-generic.c with 87% similarity]
sysdeps/riscv/multiarch/memcpy_noalignment.S [new file with mode: 0644]
sysdeps/unix/sysv/linux/riscv/Makefile
sysdeps/unix/sysv/linux/riscv/hwprobe.c
sysdeps/unix/sysv/linux/riscv/include/sys/hwprobe.h [new file with mode: 0644]
sysdeps/unix/sysv/linux/riscv/multiarch/Makefile [new file with mode: 0644]
sysdeps/unix/sysv/linux/riscv/multiarch/ifunc-impl-list.c [moved from sysdeps/riscv/memcopy.h with 51% similarity]
sysdeps/unix/sysv/linux/riscv/multiarch/memcpy.c [moved from sysdeps/riscv/memcpy.c with 90% similarity]