| commit | 1e25112dc0cb2515d27d8d178b1ecce778a9d37a | |
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | |
| Mon, 5 Feb 2024 16:10:24 +0000 (5 16:10 +0000) | ||
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | |
| Mon, 5 Feb 2024 18:29:23 +0000 (5 15:29 -0300) | ||
| tree | d1c9369f35fdda497d93c186c92e4a7e529dab0e | treesnapshot (tar.gz zip) |
| parent | 2e80f139376450acdb7d879d799439578a41810e | commitdiff |
arm: Remove wrong ldr from _dl_start_user (BZ 31339)
The commit 49d877a80b29d3002887b084eec6676d9f5fec18 (arm: Remove
_dl_skip_args usage) removed the _SKIP_ARGS literal, which was
previously loader to r4 on loader _start. However, the cleanup did not
remove the following 'ldr r4, [sl, r4]' on _dl_start_user, used to check
to skip the arguments after ld self-relocations.
In my testing, the kernel initially set r4 to 0, which makes the
ldr instruction just read the _GLOBAL_OFFSET_TABLE_. However, since r4
is a callee-saved register; a different runtime might not zero
initialize it and thus trigger an invalid memory access.
Checked on arm-linux-gnu.
Reported-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
The commit 49d877a80b29d3002887b084eec6676d9f5fec18 (arm: Remove
_dl_skip_args usage) removed the _SKIP_ARGS literal, which was
previously loader to r4 on loader _start. However, the cleanup did not
remove the following 'ldr r4, [sl, r4]' on _dl_start_user, used to check
to skip the arguments after ld self-relocations.
In my testing, the kernel initially set r4 to 0, which makes the
ldr instruction just read the _GLOBAL_OFFSET_TABLE_. However, since r4
is a callee-saved register; a different runtime might not zero
initialize it and thus trigger an invalid memory access.
Checked on arm-linux-gnu.
Reported-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
| sysdeps/arm/dl-machine.h | diffblobblamehistory |