From cca1704897e7fdb182f68d4c48a437c5d7bc5203 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Fri, 2 Jan 2009 19:07:52 +0100 Subject: [PATCH] git wrapper: Make while loop more reader-friendly It is not a good practice to prefer performance over readability in something as performance uncritical as finding the trailing slash of argv[0]. So avoid head-scratching by making the loop user-readable, and not hyper-performance-optimized. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- git.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/git.c b/git.c index 940a498962..e0d9071358 100644 --- a/git.c +++ b/git.c @@ -428,9 +428,8 @@ int main(int argc, const char **argv) * name, and the dirname as the default exec_path * if we don't have anything better. */ - do - --slash; - while (cmd <= slash && !is_dir_sep(*slash)); + while (cmd <= slash && !is_dir_sep(*slash)) + slash--; if (cmd <= slash) { *slash++ = 0; git_set_argv0_path(cmd); -- 2.11.4.GIT