| commit | d64ea0f83bd7e676778f833c57f969a94518a28d | |
| author | Jeff King <peff@peff.net> | |
| Tue, 13 Jan 2015 01:57:37 +0000 (12 20:57 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 13 Jan 2015 18:03:30 +0000 (13 10:03 -0800) | ||
| tree | a823ee7016046bdd3f6d2d9454b6a07260f28182 | treesnapshot (tar.gz zip) |
| parent | 1da1e07c835e900337714cfad6c32a8dc0b36ac3 | commitdiff |
git-compat-util: add xstrdup_or_null helper
It's a common idiom to duplicate a string if it is non-NULL,
or pass a literal NULL through. This is already a one-liner
in C, but you do have to repeat the name of the string
twice. So if there's a function call, you must write:
const char *x = some_fun(...);
return x ? xstrdup(x) : NULL;
instead of (with this patch) just:
return xstrdup_or_null(some_fun(...));
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
It's a common idiom to duplicate a string if it is non-NULL,
or pass a literal NULL through. This is already a one-liner
in C, but you do have to repeat the name of the string
twice. So if there's a function call, you must write:
const char *x = some_fun(...);
return x ? xstrdup(x) : NULL;
instead of (with this patch) just:
return xstrdup_or_null(some_fun(...));
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-compat-util.h | diffblobblamehistory |