| commit | 2140b14064ffe6b12ba6818b2894d1461a943fb9 | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Fri, 25 Feb 2011 09:07:57 +0000 (25 03:07 -0600) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 25 Feb 2011 20:13:55 +0000 (25 12:13 -0800) | ||
| tree | 5686a2f43ce2edcfed88b706346733da8bbc4691 | treesnapshot (tar.gz zip) |
| parent | da656f17d37fe96454645c08f21a24134f5aa900 | commitdiff |
commit: error out for missing commit message template
When "git commit" was rewritten in C (v1.5.4-rc0~78^2~30,
2007-11-08), a subtle bug in --template was introduced. If the
file named by a --template parameter is missing, previously git
would error out with a message:
Commit template file does not exist.
but in the C version the --template parameter gets ignored and
the default template is used.
t7500 has two tests for this case which would have caught it, except
that with the default $EDITOR, the commit message template is left
unmodified, causing 'git commit' to error out and the test to
succeed.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When "git commit" was rewritten in C (v1.5.4-rc0~78^2~30,
2007-11-08), a subtle bug in --template was introduced. If the
file named by a --template parameter is missing, previously git
would error out with a message:
Commit template file does not exist.
but in the C version the --template parameter gets ignored and
the default template is used.
t7500 has two tests for this case which would have caught it, except
that with the default $EDITOR, the commit message template is left
unmodified, causing 'git commit' to error out and the test to
succeed.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/commit.c | diffblobblamehistory | |
| t/t7500-commit.sh | diffblobblamehistory |