From 8fa7975b076ae039f63286601f48e64115e2aba7 Mon Sep 17 00:00:00 2001 From: Alexander Kuleshov Date: Mon, 2 Mar 2015 18:02:37 +0600 Subject: [PATCH] git: make was_alias and done_help non-static 'was_alias' variable does not need to store it's value on each iteration in the loop; this variable gets assigned the result of run_argv() every time in the loop before being used. 'done_help' variable does not need to be static variable too if we move it out the loop. Signed-off-by: Alexander Kuleshov Helped-by: Eric Sunshine Helped-by: Jeff King Signed-off-by: Junio C Hamano --- git.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/git.c b/git.c index 6b5ae6a2ac..29268d2f8e 100644 --- a/git.c +++ b/git.c @@ -618,6 +618,7 @@ int main(int argc, char **av) { const char **argv = (const char **) av; const char *cmd; + int done_help = 0; startup_info = &git_startup_info; @@ -680,9 +681,7 @@ int main(int argc, char **av) setup_path(); while (1) { - static int done_help = 0; - static int was_alias = 0; - was_alias = run_argv(&argc, &argv); + int was_alias = run_argv(&argc, &argv); if (errno != ENOENT) break; if (was_alias) { -- 2.11.4.GIT