| commit | e6821d09e4655af94f9c8af07333ae710094996a | |
| author | Jeff King <peff@peff.net> | |
| Wed, 25 Mar 2015 05:29:52 +0000 (25 01:29 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 25 Mar 2015 17:25:27 +0000 (25 10:25 -0700) | ||
| tree | f8c82901ba5cff198cd624354a06b907d88ebcf0 | treesnapshot (tar.gz zip) |
| parent | 76e057dba29af1f322a19cb75b2921010dbe459c | commitdiff |
t: fix some trivial cases of ignored exit codes in loops
These are all cases where we do a setup step of the form:
for i in $foo; do
set_up $i || break
done &&
more_setup
would not notice a failure in set_up (because break always
returns a 0 exit code). These are just setup steps that we
do not expect to fail, but it does not hurt to be defensive.
Most can be fixed by converting the "break" to a "return 1"
(since we eval our tests inside a function for just this
purpose). A few of the loops are inside subshells, so we can
use just "exit 1" to break out of the subshell. And a few
can actually be made shorter by just unrolling the loop.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
These are all cases where we do a setup step of the form:
for i in $foo; do
set_up $i || break
done &&
more_setup
would not notice a failure in set_up (because break always
returns a 0 exit code). These are just setup steps that we
do not expect to fail, but it does not hurt to be defensive.
Most can be fixed by converting the "break" to a "return 1"
(since we eval our tests inside a function for just this
purpose). A few of the loops are inside subshells, so we can
use just "exit 1" to break out of the subshell. And a few
can actually be made shorter by just unrolling the loop.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>