| commit | 1d4974c9bcbe3c9c0611cb056730d49c6b0b6b5e | |
| author | Jeff King <peff@peff.net> | |
| Mon, 23 Mar 2015 03:53:56 +0000 (22 23:53 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 23 Mar 2015 04:39:16 +0000 (22 21:39 -0700) | ||
| tree | 3d710c85d3e6be3db6663d4628bbb50df66266f5 | treesnapshot (tar.gz zip) |
| parent | 5c950e9bf098b17bb37e06f7c9f50d24e9d2904f | commitdiff |
submodule: use capture_command
In is_submodule_commit_present, we call run_command followed
by a pipe read, which is prone to deadlock. It is unlikely
to happen in this case, as rev-list should never produce
more than a single line of output, but it does not hurt to
avoid an anti-pattern (and using the helper simplifies the
setup and cleanup).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In is_submodule_commit_present, we call run_command followed
by a pipe read, which is prone to deadlock. It is unlikely
to happen in this case, as rev-list should never produce
more than a single line of output, but it does not hurt to
avoid an anti-pattern (and using the helper simplifies the
setup and cleanup).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| submodule.c | diffblobblamehistory |