| commit | cbfd5e1cbb539b82a34195efd0edde20d45a6439 | |
| author | Jeff King <peff@peff.net> | |
| Thu, 21 Mar 2013 11:10:28 +0000 (21 07:10 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 21 Mar 2013 21:06:38 +0000 (21 14:06 -0700) | ||
| tree | e61d22ec111804500b0f6396269ac3e9008e3bd1 | treesnapshot (tar.gz zip) |
| parent | 4db34cc134978012cf3f1b07de981a0418ed1523 | commitdiff |
drop some obsolete "x = x" compiler warning hacks
In cases where the setting and access of a variable are
protected by the same conditional flag, older versions of
gcc would generate a "might be used unitialized" warning. We
silence the warning by initializing the variable to itself,
a hack that gcc recognizes.
Modern versions of gcc are smart enough to get this right,
going back to at least version 4.3.5. gcc 4.1 does get it
wrong in both cases, but is sufficiently old that we
probably don't need to care about it anymore.
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In cases where the setting and access of a variable are
protected by the same conditional flag, older versions of
gcc would generate a "might be used unitialized" warning. We
silence the warning by initializing the variable to itself,
a hack that gcc recognizes.
Modern versions of gcc are smart enough to get this right,
going back to at least version 4.3.5. gcc 4.1 does get it
wrong in both cases, but is sufficiently old that we
probably don't need to care about it anymore.
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/cat-file.c | diffblobblamehistory | |
| fast-import.c | diffblobblamehistory |