From ec145c9c2ef0ddf0ca8b57b968054f4db9de63b3 Mon Sep 17 00:00:00 2001 From: Ramsay Jones Date: Sun, 6 Oct 2013 21:50:00 +0100 Subject: [PATCH] wrapper.c: only define gitmkstemps if needed When the NO_MKSTEMPS build variable is not set, the gitmkstemps function is dead code. Use a preprocessor conditional to only include the definition when needed. Noticed by sparse. ("'gitmkstemps' was not declared. Should it be static?") Signed-off-by: Ramsay Jones Signed-off-by: Jonathan Nieder --- wrapper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wrapper.c b/wrapper.c index f92b147598..9a6aaafaf3 100644 --- a/wrapper.c +++ b/wrapper.c @@ -360,10 +360,12 @@ int git_mkstemp_mode(char *pattern, int mode) return git_mkstemps_mode(pattern, 0, mode); } +#ifdef NO_MKSTEMPS int gitmkstemps(char *pattern, int suffix_len) { return git_mkstemps_mode(pattern, suffix_len, 0600); } +#endif int xmkstemp_mode(char *template, int mode) { -- 2.11.4.GIT