From c82efafcfa741cdddbc68379c1905953f58ef21d Mon Sep 17 00:00:00 2001 From: Brandon Casey Date: Tue, 14 Oct 2008 15:30:21 -0500 Subject: [PATCH] remote.c: correct the check for a leading '/' in a remote name This test is supposed to disallow remote entries in the config file of the form: [remote "/foobar"] ... The leading slash in '/foobar' is not acceptable. Instead it was incorrectly testing that the subkey had no leading '/', which had no effect since the subkey pointer was made to point at a '.' in the preceding lines. Signed-off-by: Brandon Casey Acked-by: Daniel Barkalow Signed-off-by: Junio C Hamano --- remote.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/remote.c b/remote.c index 105668f8a3..7688f3b04d 100644 --- a/remote.c +++ b/remote.c @@ -342,13 +342,14 @@ static int handle_config(const char *key, const char *value, void *cb) if (prefixcmp(key, "remote.")) return 0; name = key + 7; + if (*name == '/') { + warning("Config remote shorthand cannot begin with '/': %s", + name); + return 0; + } subkey = strrchr(name, '.'); if (!subkey) return error("Config with no key for remote %s", name); - if (*subkey == '/') { - warning("Config remote shorthand cannot begin with '/': %s", name); - return 0; - } remote = make_remote(name, subkey - name); if (!strcmp(subkey, ".mirror")) remote->mirror = git_config_bool(key, value); -- 2.11.4.GIT