| commit | 190c1cda7eb6dc03be80f45d3d174c313d23da2c | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Sun, 14 Feb 2010 12:06:10 +0000 (14 06:06 -0600) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 15 Feb 2010 02:23:17 +0000 (14 18:23 -0800) | ||
| tree | 09e0a5d856e692958e99a01fb5e1a57241999647 | treesnapshot (tar.gz zip) |
| parent | 06300d9753349a83212360445d241d70a46375fa | commitdiff |
git svn: Fix launching of pager
In commit dec543e (am -i, git-svn: use "git var GIT_PAGER"), I tried
to teach git svn to defer to git var on what pager to use. In the
process, I introduced two bugs:
- The value set for $pager in config_pager has local scope, so
run_pager never sees it;
- git var cannot tell whether git svn’s output is going to a
terminal, so the value chosen for $pager does not reflect that
information.
Fix them.
Reported-by: Sebastian Celis <sebastian@sebastiancelis.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In commit dec543e (am -i, git-svn: use "git var GIT_PAGER"), I tried
to teach git svn to defer to git var on what pager to use. In the
process, I introduced two bugs:
- The value set for $pager in config_pager has local scope, so
run_pager never sees it;
- git var cannot tell whether git svn’s output is going to a
terminal, so the value chosen for $pager does not reflect that
information.
Fix them.
Reported-by: Sebastian Celis <sebastian@sebastiancelis.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-svn.perl | diffblobblamehistory |