| commit | 0d4cc1b45bf063b3a46654098a9fb85f82f386a7 | |
| author | Jeff King <peff@peff.net> | |
| Sun, 31 Jan 2016 11:25:26 +0000 (31 06:25 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 1 Feb 2016 21:43:02 +0000 (1 13:43 -0800) | ||
| tree | cdbec1f4d3567ad741bf47ddcce82f021a97fbdd | treesnapshot (tar.gz zip) |
| parent | 1a0c8dfd89475d6bb09ddee8c019cf0ae5b3bdc2 | commitdiff |
give "nbuf" strbuf a more meaningful name
It's a common pattern in our code to read paths from stdin,
separated either by newlines or NULs, and unquote as
necessary. In each of these five cases we use "nbuf" to
temporarily store the unquoted value. Let's give it the more
meaningful name "unquoted", which makes it easier to
understand the purpose of the variable.
While we're at it, let's also static-initialize all of our
strbufs. It's not wrong to call strbuf_init, but it
increases the cognitive load on the reader, who might wonder
"do we sometimes avoid initializing them? why?".
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
It's a common pattern in our code to read paths from stdin,
separated either by newlines or NULs, and unquote as
necessary. In each of these five cases we use "nbuf" to
temporarily store the unquoted value. Let's give it the more
meaningful name "unquoted", which makes it easier to
understand the purpose of the variable.
While we're at it, let's also static-initialize all of our
strbufs. It's not wrong to call strbuf_init, but it
increases the cognitive load on the reader, who might wonder
"do we sometimes avoid initializing them? why?".
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>