From d0f28b64b065604361518a5ed51685fc11db7c00 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Thu, 12 Feb 2009 02:30:17 +0100 Subject: [PATCH] make install: warn about a "git" in GIT_EXEC_PATH We do not install "git" in the exec path. However, if there is one, scripts calling builtins with the dash-less form use the wrong command. For example, if that binary contains an obsolete form of pack-objects and you call "git gc" -- which uses the dash-less form as recommended -- it may error out because the old pack-objects does not understand new options. Signed-off-by: Johannes Schindelin --- check_bindir | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/check_bindir b/check_bindir index a1c4c3e8d8..4e497b4120 100755 --- a/check_bindir +++ b/check_bindir @@ -11,3 +11,11 @@ then echo "!! Please remove old version commands in bindir now." echo fi +if test "$bindir" != "$gitexecdir" -a \ + -x "${gitexecdir#z}"/git"$(expr "$gitcmd" : '.*\(\..*\)')" +then + echo + echo "!! You have installed git to new gitexecdir." + echo "!! This will likely cause problems, as it will become stale." + echo +fi -- 2.11.4.GIT