| commit | 40e9136ff641682e2ef739a3dbce03047ed5426f | |
| author | Patrick Steinhardt <ps@pks.im> | |
| Mon, 6 Nov 2023 10:45:53 +0000 (6 11:45 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 6 Nov 2023 23:51:40 +0000 (7 08:51 +0900) | ||
| tree | 32194f6d4238e1b9605b0f37a6d52e236d230d72 | treesnapshot (tar.gz zip) |
| parent | 61a22ddaf0626111193a17ac12f366bd6d167dff | commitdiff |
test-bloom: stop setting up Git directory twice
We're setting up the Git directory twice in the `test-tool bloom`
helper, once at the beginning of `cmd_bloom()` and once in the local
subcommand implementation `get_bloom_filter_for_commit()`. This can lead
to memory leaks as we'll overwrite variables of `the_repository` with
newly allocated data structures. On top of that it's simply unnecessary.
Fix this by only setting up the Git directory once.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We're setting up the Git directory twice in the `test-tool bloom`
helper, once at the beginning of `cmd_bloom()` and once in the local
subcommand implementation `get_bloom_filter_for_commit()`. This can lead
to memory leaks as we'll overwrite variables of `the_repository` with
newly allocated data structures. On top of that it's simply unnecessary.
Fix this by only setting up the Git directory once.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/helper/test-bloom.c | diffblobblamehistory |