| commit | 296d6737331f6287f6be60f6230b51760ed11f98 | |
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | |
| Wed, 2 Mar 2016 19:11:13 +0000 (2 20:11 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 2 Mar 2016 20:33:43 +0000 (2 12:33 -0800) | ||
| tree | 1bf01796f755841e5680843768477152e1de35de | treesnapshot (tar.gz zip) |
| parent | 326e5bc91eecf73234ead29636207bc516573e79 | commitdiff |
Mark win32's pthread_exit() as NORETURN
The pthread_exit() function is not expected to return. Ever. On Windows,
we call ExitThread() whose documentation claims: "Ends the calling
thread", i.e. there is no condition in which this function simply
returns: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
While at it, fix the return type to be void, as per
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html
Pointed out by Jeff King, helped by Stefan Naewe, Junio Hamano &
Johannes Sixt.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The pthread_exit() function is not expected to return. Ever. On Windows,
we call ExitThread() whose documentation claims: "Ends the calling
thread", i.e. there is no condition in which this function simply
returns: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
While at it, fix the return type to be void, as per
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html
Pointed out by Jeff King, helped by Stefan Naewe, Junio Hamano &
Johannes Sixt.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| compat/win32/pthread.h | diffblobblamehistory |